From 8b28731c9c91e13495ced1bc18b2b40f1dbe2ea4 Mon Sep 17 00:00:00 2001 From: Michelle Shepardson Date: Wed, 28 Feb 2024 01:04:42 +0000 Subject: [PATCH] Clarify message for missing podinfo.json. TestGrid expects that podinfo.json is uploaded by the time that finished.json is, and will either report it as a running/pending status if finished.json isn't uploaded yet, or as a failure if it is. The message that appears on the .Pod cell isn't clear about this case, so updating the message to include it. (The previous case mentioned, where Prow's GCS reporter isn't enabled, still applies, but podinfo.json can fail to be uploaded for other reasons as well). --- util/gcs/read.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/gcs/read.go b/util/gcs/read.go index e97d2abb0..b728a7a3c 100644 --- a/util/gcs/read.go +++ b/util/gcs/read.go @@ -44,9 +44,9 @@ type PodInfo struct { const ( // MissingPodInfo appears when builds complete without a podinfo.json report. - MissingPodInfo = "podinfo.json not found, please install prow's GCS reporter" + MissingPodInfo = "podinfo.json not found in job artifacts (has not uploaded, or Prow's GCS reporter is not enabled)." // NoPodUtils appears when builds run without decoration. - NoPodUtils = "not using decoration, please set decorate: true on prowjob" + NoPodUtils = "Decoration is not enabled; set `decorate: true` on Prowjob." ) func truncate(s string, max int) string {