Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support test docker-env for containerd runtime #41

Merged
merged 1 commit into from
Nov 6, 2023
Merged

feat: support test docker-env for containerd runtime #41

merged 1 commit into from
Nov 6, 2023

Conversation

ComradeProgrammer
Copy link
Contributor

@ComradeProgrammer ComradeProgrammer commented Nov 4, 2023 •
edited
Loading

feat: support test docker-env for containerd runtime

After:
You can run docker-env test for containerd like this

$ ./out/benchmark --runs=2 --images=buildpacksFewSmallFiles --iters="iterative" --bench-methods="docker-env containerd"
Benchmark buildpacksFewLargeFiles on image load docker ( iterative) is skipped
...
Running buildpacksFewSmallFiles on docker-env containerd iterative
Run #1  took 83.48 seconds
Run #2  took 5.83 seconds
Benchmark buildpacksManyLargeFiles on docker-env containerd ( iterative) is skipped
...

Before:
Docker-env containerd was not supported before

FIX #38

@medyagh medyagh merged commit f8e2d0f into GoogleContainerTools:main Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add docker-env for containerd support
2 participants
@ComradeProgrammer @medyagh