-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation is inconsistent about which element to use or not. #143
Comments
google-signin docs are correct. google-signin-aware docs did not get updated when code was rewritten. Pull requests welcome :) |
The demo also seems to be in line with the google-signin-aware docs, if I understood what actually was expected, I would be happy to update things, but at this level of confusion, w/zero knowledge of the elements, updating documentation would probably be the least helpful thing I could do right now. |
Hi @ktiedt I'll take a stab at updating the documentation. Sorry that it isn't very clear. The idea is that there is at least one signin button on the page using the |
|
That is true, developers can also manually trigger the signin. I'll be sure to mention that. |
Ahh, so signin-aware is actually the brains, the -aware makes it sound more like a secondary element. Sorting that out in my head makes things a lot more clear |
Yeah, if you look at the https://github.com/GoogleWebComponents/google-signin/blob/master/google-signin.html#L536 |
|
…in` works. Also provides guidance on how to use the `google-signin-aware` with custom signin UIs. Closes #143
In google-signin element you state:
And in google-signin-aware you state:
The former seems to imply a signin element is not needed, the latter implies it is required... Which begs the question, is the only purpose of signin-aware to notify you of states of specific scopes?
The text was updated successfully, but these errors were encountered: