review <number> : number is ignored in some cases

[mrVanDalo]

tasksh> review 30

works if 0 is the last element before pressing enter.
but if 0 is followed by a space (or multiple spaces) the number ( 30 ) will be ignored.

[ThomasAdam]

Which version of tasksh is this? I can't seem to reproduce this, unless I'm being an idiot? With any number, if I do:

review 11 [4 spaces]

or:

review 11 [no spaces here, press enter]

I get the same result.

This is with tasksh version 1.2.0 and 1.3.0.

[mrVanDalo]

here a small log :

tasksh                                                              ✔  01:58:41 
tasksh 1.2.0                         

  Commands:
    tasksh> list             Or any other Taskwarrior command
    tasksh> review [N]       Task review session, with optional cutoff after N tasks
    tasksh> exec ls -al      Any shell command.  May also use '!ls -al'
    tasksh> help             Tasksh help
    tasksh> diagnostics      Tasksh diagnostics
    tasksh> quit             End of session. May also use 'exit'

Run 'man tasksh' from your shell prompt.
Run '! man tasksh' from inside tasksh.

tasksh> review 1 
....
End of review. 0 out of 71 tasks reviewed.

tasksh> 

I typed in review 1 [ one space ] [ enter ]

[ThomasAdam]

OK, I see why. In main.cpp we do this: auto args = split (command, ' '); which really messes with leading and trailing whitespace. Patch to follow to normalise this case, and to handle things like: command foo foo

[mrVanDalo]

@ThomasAdam so this is a bug (existing everywhere, not only on my machine) ?

[ThomasAdam]

Yes, it's a bug.

[ThomasAdam]

Please test the proposed patch which should fix your issue.