Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix React sidebar menu height #43

Closed
gregelin opened this issue Nov 21, 2021 · 1 comment
Closed

Fix React sidebar menu height #43

gregelin opened this issue Nov 21, 2021 · 1 comment
Labels
bug Something isn't working design improving look and feel frontend Related to front end

Comments

@gregelin
Copy link
Contributor

gregelin commented Nov 21, 2021 •
edited
Loading

Bug

The left hand navigation vertical sizing is not accurately reaching 100% of the height.

To Reproduce

View the following pages:

develop branch:
http://localhost:8000/projects/1/govready-q-sample-system - long lefthand nav

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome, Safari, etc.
  • Version [e.g. 22]
  • Any

Expected behavior

The lefthand navigation should always be 100% height of the browser.

Screenshots

How the lefthand nav looks at the top:

image

How the lefthand nav falls short in the main branch:

image

How the lefthand nav is set is just set very tall in the develop branch (with better footer)

image

image

Developer hints

  • hint

Acceptance criteria

  • criteria

Reference
@gregelin gregelin added bug Something isn't working design improving look and feel frontend Related to front end labels Nov 21, 2021
@gregelin gregelin changed the title Fix CSS sizing of lefthand navigation Fix React sidebar menu height Dec 17, 2021
@gregelin
Copy link
Contributor Author

Closed in #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working design improving look and feel frontend Related to front end
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregelin @kerryrm @ward438