Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid url after reopening the app #3

Open
illionas opened this issue Jun 11, 2021 · 7 comments
Open

invalid url after reopening the app #3

illionas opened this issue Jun 11, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@illionas
Copy link

https://github.com/GrantMoyer/passphrase-generator, v1.0.0.
Created by Grant Moyer ([email protected]),
invalid

In the settings, after reopening the app. The plugin page tells me that the plugin would be "invalid". The url it mentions leads to a 404 page on github.

@GrantMoyer GrantMoyer self-assigned this Jun 11, 2021
@GrantMoyer GrantMoyer added the bug Something isn't working label Jun 11, 2021
@GrantMoyer
Copy link
Owner

I think this might have been a transient error, because I cannot reproduce this. @illionas is this still an issue for you?

@DanielHilpoltsteiner
Copy link

I don't know if it is an issue for @illionas, but for me it is the same.
I am using the current keeweb version 1.18.7 and your generator 1.1.0

This is the error i get in dev console:

2021-10-30T21:17:23.407Z [plugin:passphrase-generator] Manifest validation error Public key mismatch
r.error @ index.html:1

hope that helps

@kifujin
Copy link

kifujin commented Nov 9, 2021

Could it be because of the manifest.json having the wrong URL in it?

"url": "https://github.com/GrantMoyer/passphrase-generator",

@GrantMoyer
Copy link
Owner

@kifujin Thanks for pointing out the wrong url, but that shouldn't cause this issue.

I've reproduced the issue now, and I think this might be a problem in keeweb. It looks like it checks all plugins public keys against a fixed list.

@GrantMoyer
Copy link
Owner

Yeah, this is a design choice by KeeWeb; see keeweb/keeweb#1954. I'll see if I can get this plugin added to the gallery.

@nevyen
Copy link

nevyen commented May 30, 2022

Are there any news on this?

I want to use this plugin but can't install it in my selfhosted keeweb.

@GrantMoyer
Copy link
Owner

@nevyen I polished up the passphrase generator plugin and submitted keeweb/keeweb-plugins#30. Getting the passphrase generator in a state I felt was polished enough to be included in the plugin gallery required changes to keeweb itself, which I submitted at keeweb/keeweb#2002. Both those changes are waiting on keeweb to get a new maintainer to approve them; see keeweb/keeweb#2022.

In the meantime, the response in keeweb/keeweb#1954 says:

plugins can be for now permanently added only in self-hosted installations using a config file

I don't self host KeeWeb, I just use the desktop app, so I don't know what config to change. If you've tried this, and it didn't work, feel free to open another issue with some details, and I'll see if I can fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants