Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duplicate logic of NoSuchProcess detection #136

Open
Jongy opened this issue Apr 2, 2023 · 0 comments
Open

Merge duplicate logic of NoSuchProcess detection #136

Jongy opened this issue Apr 2, 2023 · 0 comments

Comments

@Jongy
Copy link
Contributor

Jongy commented Apr 2, 2023

We have 2 different implementations that detect a "NoSuchProcess" state when reading ELF files of processes -

def raise_nosuchprocess(func: Callable[P, R]) -> Callable[P, R]:
and
def translate_proc_errors(process: psutil.Process) -> Generator[None, None, None]:
.

Personally I prefer the latter, and it seems more complete. Let's remove either and fix all sites to use a single one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant