Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write unit tests for Duplicate Entry #1377

Closed
zackkatz opened this issue Nov 20, 2019 · 2 comments
Closed

Write unit tests for Duplicate Entry #1377

zackkatz opened this issue Nov 20, 2019 · 2 comments
Assignees
@soulseekah

Comments

@zackkatz
Copy link
Member

Needs tests, but only after #1345 is taken care. We want green.

Can you add some tests, regardless of the color?

Originally posted by @zackkatz in #1360 (comment)
@soulseekah
Copy link
Contributor

A todo of #930

soulseekah added a commit that referenced this issue Nov 25, 2019
@soulseekah
Add user_duplicate setting to View
87b48ce 
Related to #1377 and #930
soulseekah added a commit that referenced this issue Nov 25, 2019
@soulseekah
Duplicate fine-tunes
882b48c 
Public the duplicate nonce
Don't HTML-encode the duplicate link

More on #1377 and #930
soulseekah added a commit that referenced this issue Nov 25, 2019
@soulseekah
Initial set of green tests for duplicate
7418267 
For #1377
soulseekah added a commit that referenced this issue Nov 26, 2019
@soulseekah
Add more cap passes to duplicate entry
d18ace8 
also fix legacy gravityview_get_current_view_data() call

All work on #1377 and #980
soulseekah added a commit that referenced this issue Nov 26, 2019
@soulseekah
More tests on #1377
5c975c2
soulseekah added a commit that referenced this issue Nov 26, 2019
@soulseekah
Finalized tests for #1377
99674ac
@soulseekah
Copy link
Contributor

And I'm done I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soulseekah soulseekah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soulseekah @zackkatz