Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who's currently editing feature suggestion #877

Closed
rafaehlers opened this issue Apr 17, 2017 · 13 comments
Closed

Who's currently editing feature suggestion #877

rafaehlers opened this issue Apr 17, 2017 · 13 comments

Comments

@rafaehlers
Copy link
Contributor

rafaehlers commented Apr 17, 2017

Here's a suggestion for the Edit Entry page from one of our users:

When using gravity view with multiple editors, editing the same content, its critical to have the option to >display two kinds of messages to a user.

  1. Currently in edit mode by: "userid" (or any info from the user profile).
  2. Last edited by: "userid", on "last-modified-date".
    As V2 for the feature to have an option to limit access to the edit mode if the entry is currently being edited by specific roles.

Gravity Forms supports this with GFEntryLocking; add this to Edit Entry when an entry is being edited as well.

@rafaehlers
Copy link
Contributor Author

@zackkatz
Copy link
Member

This would use Gravity Forms' built-in GFAddonLocking system.

@soulseekah
Copy link
Contributor

Duplicate #950

@zackkatz
Copy link
Member

Also requested by HS#12546

@soulseekah
Copy link
Contributor

The Heartbeat API is also nice.

https://developer.wordpress.org/plugins/javascript/heartbeat-api/

@soulseekah soulseekah self-assigned this Oct 22, 2019
@soulseekah soulseekah mentioned this issue Oct 29, 2019
@soulseekah
Copy link
Contributor

Since we will have to synchronize with the edit backend we'll have to use GFEntryLocking for sure, piggyback off its functionality as suggested by Rafael.

@soulseekah
Copy link
Contributor

image

Almost there.

@soulseekah
Copy link
Contributor

Jesus the whole heartbeat thing they have setup is pretty feeble. Breaks 50% of the time when testing the backend manually. Our thing will behave in a similar unreliable way :) for now.

@zackkatz
Copy link
Member

@soulseekah it should also prevent non-admins from being able to edit at all. Can you write a doc with how it’s supposed to work, so we can test against that?

@soulseekah
Copy link
Contributor

All edit locks are purely advisory and are JavaScript based. It's very simple to bypass them. Just like it's easy to bypass Post locks in WordPress. It has nothing to do with user permissions, @zackkatz. Let me know if I'm missing something, please.

soulseekah added a commit that referenced this issue Nov 16, 2019
@soulseekah
Copy link
Contributor

This is ready to be tested. It's pretty raw but it should work overall. I've done a lot on my end but you guys might manage to break things :)

@soulseekah soulseekah removed their assignment Nov 19, 2019
@soulseekah
Copy link
Contributor

The AJAX heartbeat/lock refresh end of things have to be tested as well here.

@zackkatz
Copy link
Member

Added in 2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants