Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiblock boiler pollution scales strangely with fuel burn duration #1906

Open
2 tasks done
ZSusskind opened this issue Sep 8, 2024 · 0 comments
Open
2 tasks done
Labels
type: bug Something isn't working

Comments

@ZSusskind
Copy link

Checked for existing issues

  • I have checked for existing issues, and have found none.

Tested latest version

  • I have checked that this occurs on the latest version.

GregTech CEu Version

v1.4.0 build 1067

Minecraft Version

1.20.1

Recipe Viewer Installed

None

Environment

Singleplayer

Cross-Mod Interaction

No

Other Installed Mods

None

Expected Behavior

The rate at which multiblock boilers produce pollution should be independent of their fuel type.

Actual Behavior

A constant amount of pollution instead appears to be produced for each item burned. This means that boilers using fuels with short burn durations will produce massive amounts of pollution, while boilers using fuels with very long burn durations will produce essentially none.

Steps to Reproduce

  1. Construct two large bronze boilers (or similar), several chunks away from each other. I used all LV hatches, but I don't think the exact choice matters.
  2. Fuel one boiler using an item with a short burn duration (e.g., sticks), and the other with an item with a long burn duration (e.g., blocks of coke).
  3. Observe the pollution emitted by both boilers using a portable debug scanner. The boiler with the short-duration fuel will emit vastly more pollution.

Additional Information

This is likely because the getHazardStrengthPerOperation() function in api/machine/feature/multiblock/IMufflerMachine.java does not consider the duration of operations, and burning a single fuel item is treated as an operation. Boilers emitting more pollution with low-quality fuels could be an interesting mechanic, but it's excessive in its current form and results in silly behaviors like blocks of charcoal creating 9x less pollution than individual charcoal items.

@ZSusskind ZSusskind added the type: bug Something isn't working label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant