Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patches for GCC 5.4.0 #65

Open
piranna opened this issue Feb 26, 2017 · 3 comments
Open

Add patches for GCC 5.4.0 #65

piranna opened this issue Feb 26, 2017 · 3 comments

Comments

@piranna
Copy link

piranna commented Feb 26, 2017

Add patches for GCC 5.4.0 since it's the latest one available for the 5.x branch. Also, add the patches to allow to compile it with GCC 6.x.x and newer.

@rofl0r
Copy link
Collaborator

rofl0r commented Feb 26, 2017

this sounds like the commit message of a pull request. but i can't see any patches attached here...
did you see the comment about "project scope" in the README ?

@piranna
Copy link
Author

piranna commented Feb 26, 2017

Yes, I've read it, but in fact the other repo is too much difficult to understand how to integrate it. Seems the other repo generates a full cross-toolchain, that's not a bad thing, but I'm using my own one (nodeos-cross-toolchain) so I'm only interested on the GCC patch and no more. Current patches are easy to apply but the ones on the other repo it's not clear about how to apply them, so since it's from the same 5.x branch, I think it would make sense to also add an upgrade here, specially having such an important bug like not being able to compile GCC with 6.x and newer ones, so I think at least the fix patch should be applied and backported here...

@rofl0r
Copy link
Collaborator

rofl0r commented Feb 27, 2017

i agree that it'd be nice to have but it's work...
as a quicky, you could try to just cat *.diff > cumulative.patch in the musl-cross-make repo in the patches/gcc-6.3.0 dir. and then add it to your toolchain or this repo here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants