Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: GreptimeRequest no longer has QueryRequest variant #154

Closed
wants to merge 2 commits into from

Conversation

tisonkun
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This refers to GreptimeTeam/greptimedb#3799.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@tisonkun tisonkun changed the title feat!: GreptimeRequest no longer has QueryRequest variant feat: GreptimeRequest no longer has QueryRequest variant Apr 27, 2024
Copy link
Collaborator

@MichaelScofield MichaelScofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can be merged only after the corresponding issue is resolved.

@tisonkun
Copy link
Contributor Author

@MichaelScofield Aha. Yes I can open a pr on the main repo and point to this commit.

Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun tisonkun marked this pull request as draft April 28, 2024 02:33
@tisonkun tisonkun changed the title feat: GreptimeRequest no longer has QueryRequest variant feat!: GreptimeRequest no longer has QueryRequest variant Apr 28, 2024
@tisonkun
Copy link
Contributor Author

tisonkun commented Jul 6, 2024

Closed for now.

@tisonkun tisonkun closed this Jul 6, 2024
@tisonkun tisonkun deleted the GreptimeRequest-no-QueryRequest branch July 6, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants