fix: fix incorrect status code

GreptimeTeam · Sep 18, 2023 · d7e1530 · d7e1530
1 parent 906ca48
commit d7e1530
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/datanode/src/alive_keeper.rs b/src/datanode/src/alive_keeper.rs
@@ -461,8 +461,8 @@ mod test {
         // wait for countdown task to finish
         let before_await = Instant::now();
         let (finish_instant, result) = rx.await.unwrap();
-        // the mock region server cannot close the region
-        assert_eq!(result, Some(false));
+        // it returns `RegionNotFound`
+        assert_eq!(result, Some(true));
         // this task should be finished after 5 * heartbeat_interval_millis
         // we assert 4 times here
         assert!(

diff --git a/src/datanode/src/error.rs b/src/datanode/src/error.rs
@@ -518,11 +518,12 @@ impl ErrorExt for Error {
             | MissingInsertBody { .. }
             | ShutdownInstance { .. }
             | JoinTask { .. }
-            | RegionNotFound { .. }
             | RegionEngineNotFound { .. }
             | UnsupportedOutput { .. }
             | GetRegionMetadata { .. } => StatusCode::Internal,
 
+            RegionNotFound { .. } => StatusCode::RegionNotFound,
+
             StartServer { source, .. }
             | ShutdownServer { source, .. }
             | WaitForGrpcServing { source, .. } => source.status_code(),