-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove or reconsider the NumbersTable
#1827
Comments
What kind of real issues you specify here? From my point of view, except: } else if schema == DEFAULT_SCHEMA_NAME && table_name == NUMBERS_TABLE_NAME {
Some(NumbersTable::table(NUMBERS_TABLE_ID)) This table impl is barely an internal testing table for convenient testing. If we don't want it pollute the main logic but only whitebox table tests, we can exclude its usage in the main process (planning/name resolution) and annotate it with cc @waynexia |
That's one. It also breaks a system-level invariant that every table should contain one
Blackbox tests use this table more often. So |
@waynexia How do we implement it or how can we check this invariant? I found Besides, it is expected to remove: } else if schema == DEFAULT_SCHEMA_NAME && table_name == NUMBERS_TABLE_NAME {
Some(NumbersTable::table(NUMBERS_TABLE_ID)) ? I'm unsure if |
What type of enhancement is this?
Tech debt reduction
What does the enhancement do?
we have a built-in system table
NumbersTable
for testing. But it's very bad implemented and brings tons of special logic.Implementation challenges
No response
The text was updated successfully, but these errors were encountered: