Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for all comparable types for greatest function #4991

Closed
0neSe7en opened this issue Nov 14, 2024 · 1 comment · Fixed by #5005
Closed

Add support for all comparable types for greatest function #4991

0neSe7en opened this issue Nov 14, 2024 · 1 comment · Fixed by #5005
Assignees
@waynexia
Labels
C-feature Category Features good first issue Good for newcomers

Comments

@0neSe7en
Copy link

What problem does the new feature solve?

The greatest function only supports date. It would be great if it could support all comparable types. For now I have to use CASE WHEN to get the greatest value.

What does the feature do?

support select greatest(v1, 100) etc.

Implementation challenges

No response
@0neSe7en 0neSe7en added the C-feature Category Features label Nov 14, 2024
@0neSe7en 0neSe7en changed the title Add support for all comparable types for 'greatest' function Add support for all comparable types for greatest function Nov 14, 2024
@waynexia waynexia self-assigned this Nov 14, 2024
@waynexia
Copy link
Member

reference to upstream: apache/datafusion#6531

@killme2008 killme2008 added the good first issue Good for newcomers label Nov 17, 2024
@killme2008 killme2008 mentioned this issue Nov 17, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waynexia waynexia

Labels
C-feature Category Features good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make greatest supports timestamp and datetime types killme2008/greptimedb
3 participants
@killme2008 @0neSe7en @waynexia