feat!: enable telemetry by default #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
changed the title
github-actions
bot
added
the
breaking-change
killme2008
added
C-documentation
killme2008
requested review from
paomian and
MichaelScofield
and removed request for
paomian
Codecov Report
@@ Coverage Diff @@
## develop #2137 +/- ##
===========================================
- Coverage 84.88% 84.50% -0.39%
===========================================
Files 696 696
Lines 110476 110614 +138
===========================================
- Hits 93781 93469 -312
- Misses 16695 17145 +450 |
|
@paomian @waynexia @MichaelScofield Please take a look, thank u. |
etolbakov
approved these changes
Aug 11, 2023
|
LGTM |
paomian
reviewed
Aug 11, 2023
killme2008
force-pushed
the
feature/enable-telemetry
branch
from
d1250d6 to
e587c2f
Compare
paomian
approved these changes
Aug 11, 2023
killme2008
force-pushed
the
feature/enable-telemetry
branch
from
e587c2f to
7070cf8
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: remove greptimedb-telemetry feature * feat: adds enable_telemetry option to metasrv and datanode * refactor: move data_home from file config to storage config * feat: store the installation uuid into datanode and metasrv working home * fix: cargo toml fmt * test: ignore region failver test when using local fle storage * test: ignore telemetry reporter in test mode * feat: print warning log when enabling telemetry * chore: the telemetry doc link * chore: remove enable_telemetry from datanode example config file * refactor: rename GREPTIMEDB_TELEMETRY_CLIENT_REQUEST_TIMEOUT * chore: rename print_warn_log to print_anonymous_usage_data_disclaimer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Main changes:
greptimedb-telemetryfeature in metasrv and datanode.enable_telemetryto datanode and metasrv configurations,trueby default.data_homefromFileConfigtoStorageConfigin datanode.data_hometo metasrv options.data_homedirectory in datanode and metasrv.Checklist
Refer to a related PR or issue link (optional)