Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove associate type in scheduler and handler to simplify flush and compaction #2153 #2163

Closed

Conversation

Nateiru
Copy link
Contributor

@Nateiru Nateiru commented Aug 13, 2023

…flush and compaction

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Flush and Compaction processes involve the Request associative type, which is polymorphic overhead leveraging static dispatching when compiled.
  • I delete the Request associative type and replace it with dyn Reqeust.
  • This design aims to reduce polymorphic overhead leveraging static dispatching. But this overhead is negligible in this case.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

closes #2153

@Nateiru Nateiru changed the title refactor: remove associate type in scheduler and handler to simplify flush and compaction #2153 refactor: remove associate type in scheduler and handler to simplify flush and compaction https://github.com/GreptimeTeam/greptimedb/issues/2153 Aug 13, 2023
@Nateiru Nateiru changed the title refactor: remove associate type in scheduler and handler to simplify flush and compaction https://github.com/GreptimeTeam/greptimedb/issues/2153 refactor: remove associate type in scheduler and handler to simplify flush and compaction #2153 Aug 13, 2023
@Nateiru Nateiru closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify scheduler for compaction/file purge
1 participant