fix: validate partition columns #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2393 +/- ##
===========================================
- Coverage 77.50% 77.45% -0.05%
===========================================
Files 716 716
Lines 113062 113100 +38
===========================================
- Hits 87634 87607 -27
- Misses 25428 25493 +65 |
MichaelScofield
force-pushed
the
fix/validate-partition-column
branch
from
04bf896
to
dc1a4ba
Compare
MichaelScofield
force-pushed
the
fix/validate-partition-column
branch
from
dc1a4ba
to
4561806
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
fix: partition column must belong to primary keys or equals to time index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Ensures that partition column must belongs to primary keys or equals to time index.
#2386 : 3/38
Checklist
Refer to a related PR or issue link (optional)