fix: alter table procedure panics while renaming table #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2397 +/- ##
===========================================
- Coverage 77.52% 77.52% -0.01%
===========================================
Files 717 717
Lines 113980 113982 +2
===========================================
- Hits 88365 88364 -1
- Misses 25615 25618 +3 |
MichaelScofield
approved these changes
Sep 14, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…2397) * fix: procedure panic on renaming table * test: fix test_insert_and_select invalid arguments * test: fix test_standalone_insert_and_query using wrong semantic type * test: fix test_distributed_insert_delete_and_query semantic type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR fixes panics while using the
AlterTableProcedureto rename a table.It fixes integration tests for renaming. It also fixes grpc tests that use incorrect semantic type. Now the following tests pass:
Checklist
Refer to a related PR or issue link (optional)