Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix open region missing path #2441

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Sep 19, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix open region missing path

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #2441 (1093d41) into develop (5805e8d) will increase coverage by 0.03%.
The diff coverage is 69.01%.

❗ Current head 1093d41 differs from pull request most recent head 7f2d900. Consider uploading reports for the commit 7f2d900 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2441      +/-   ##
===========================================
+ Coverage    77.70%   77.74%   +0.03%     
===========================================
  Files          730      730              
  Lines       115885   115931      +46     
===========================================
+ Hits         90047    90125      +78     
+ Misses       25838    25806      -32     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Sep 19, 2023
Merged via the queue into develop with commit 1fb2d95 Sep 19, 2023
10 checks passed
@fengjiachun fengjiachun deleted the fix/open-region-missing-path branch September 19, 2023 09:08
@WenyXu WenyXu added the O-chaos Found by chaos tests label Sep 19, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix: fix open region missing path

* fix: correct log

* chore: apply suggestions from CR

* fix: fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-chaos Found by chaos tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants