Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build GreptimeDB binary for later use #3244

Merged
merged 8 commits into from
Jan 31, 2024

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Reuse the built GreptimeDB binary in CI. Let's see if it can save some time and money.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 26, 2024
@MichaelScofield MichaelScofield force-pushed the ci/pre-build-bins branch 3 times, most recently from 6076a29 to 7ee6e20 Compare January 26, 2024 06:17
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (691b649) 85.78% compared to head (cedeb44) 85.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3244      +/-   ##
==========================================
- Coverage   85.78%   85.33%   -0.46%     
==========================================
  Files         856      856              
  Lines      140172   140188      +16     
==========================================
- Hits       120247   119623     -624     
- Misses      19925    20565     +640     

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17
Copy link
Collaborator

zyy17 commented Jan 26, 2024

@MichaelScofield Still have the error:

Caused by:
  process didn't exit successfully: `/greptimedb/target/debug/build/servers-18d50f6b6f3fd04d/build-script-build` (exit status: 101)
  --- stdout
  cargo:rustc-env=RUSTC_VERSION=rustc 1.76.0-nightly (3f28fe133 2023-12-18)

  --- stderr
  thread 'main' panicked at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/build-data-0.1.5/src/lib.rs:630:64:
  called `Result::unwrap()` on an `Err` value: "command 'git rev-parse --abbrev-ref=loose HEAD' failed: exit=128 stdout='' stderr='fatal: detected dubious ownership in repository at \\'/greptimedb\\'\\nTo add an exception for this directory, call:\\n\\n\\tgit config --global --add safe.directory /greptimedb\\n'"
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
make: *** [Makefile:66: build] Error 101
make: *** [Makefile:70: build-by-dev-builder] Error 2

@WenyXu
Copy link
Member

WenyXu commented Jan 29, 2024

We can use a small size machine for sqlness tests. Now, 4-CPU machines are free for open-source projects.
BTW, it could reduce compiling time if we introduce the cache. The Build binaries take 8 minutes(6min compiling, 2 min uploading) to finish the step, which is 2x the usage of the sqlness test.

@waynexia
Copy link
Member

Also the kafka and normal sqlness cases can be run in the same job

tests/runner/src/env.rs Outdated Show resolved Hide resolved
@WenyXu
Copy link
Member

WenyXu commented Jan 29, 2024

Also the kafka and normal sqlness cases can be run in the same job

BTW, I switch the sqlness runner to 4 core, Now it's free. maybe doesn't really matter.🥰

@MichaelScofield
Copy link
Collaborator Author

@zyy17 @WenyXu @waynexia PTAL

@waynexia waynexia added this pull request to the merge queue Jan 31, 2024
Merged via the queue into GreptimeTeam:main with commit 50d16d6 Jan 31, 2024
22 checks passed
@MichaelScofield MichaelScofield deleted the ci/pre-build-bins branch January 31, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants