-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flow): impl ScalarExpr&Scalar Function #3283
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3283 +/- ##
==========================================
- Coverage 85.64% 85.13% -0.52%
==========================================
Files 865 884 +19
Lines 140798 144751 +3953
==========================================
+ Hits 120593 123228 +2635
- Misses 20205 21523 +1318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add a "flow" scope in the PR title (a.k.a. feat(flow)
). It "shocks" me that we don't implement ScalarExpr for GreptimeDB, XD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add impl for ScalarExpr&Scalar Functions
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Added impl code which eval Unary, Binary and Variadic Func
Added utilty functions for
ScalarExpr
like get supporting(column being used in expression) column for a ScalarExpr.Most importantly, added utility functions for Temporal Filter, which can extract bounding condition including
now()
function and comparsion expression and express sliding windows etc.Summarize your change (mandatory)
useful methods for Scalar Expr, and
eval
method for Scalar functionChecklist
Refer to a related PR or issue link (optional)