Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allocate table ids in the procedure #3293

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Feb 7, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. refactor: allocate table ids in the procedure
  2. test: add tests for CreateTableLogicalProcedure

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3233

Waits for #3271

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8289b0d) 85.42% compared to head (227cf24) 84.99%.
Report is 1 commits behind head on main.

❗ Current head 227cf24 differs from pull request most recent head 627a86d. Consider uploading reports for the commit 627a86d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3293      +/-   ##
==========================================
- Coverage   85.42%   84.99%   -0.43%     
==========================================
  Files         889      889              
  Lines      145477   145471       -6     
==========================================
- Hits       124272   123646     -626     
- Misses      21205    21825     +620     

@WenyXu WenyXu marked this pull request as draft February 7, 2024 04:48
@WenyXu WenyXu force-pushed the enhance/create-logical-tables-ddl-procedure branch from d3b03e5 to 0c9cb66 Compare February 7, 2024 10:30
@github-actions github-actions bot added Size: XL and removed Size: M labels Feb 7, 2024
@WenyXu WenyXu marked this pull request as ready for review February 7, 2024 10:51
@WenyXu
Copy link
Member Author

WenyXu commented Feb 7, 2024

I'm going to drop the duplicate commits after #3271 is merged

@WenyXu WenyXu force-pushed the enhance/create-logical-tables-ddl-procedure branch from aaf5ab1 to 43f12cc Compare February 20, 2024 15:07
@WenyXu WenyXu force-pushed the enhance/create-logical-tables-ddl-procedure branch from 7b793cc to 227cf24 Compare February 22, 2024 08:49
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun
Copy link
Collaborator

@waynexia PTAL

@WenyXu WenyXu force-pushed the enhance/create-logical-tables-ddl-procedure branch from 31d0b57 to 627a86d Compare February 22, 2024 09:28
@MichaelScofield MichaelScofield added this pull request to the merge queue Feb 22, 2024
Merged via the queue into GreptimeTeam:main with commit 1dc4fec Feb 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants