Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade actions to node20-based version #3345

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

tisonkun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

TRIVIAL AS IS

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 21, 2024
@waynexia waynexia enabled auto-merge February 21, 2024 06:59
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9a9634) 85.28% compared to head (cd823c7) 84.86%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3345      +/-   ##
==========================================
- Coverage   85.28%   84.86%   -0.42%     
==========================================
  Files         884      884              
  Lines      144256   144256              
==========================================
- Hits       123029   122430     -599     
- Misses      21227    21826     +599     

@waynexia waynexia added this pull request to the merge queue Feb 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2024
@sunng87 sunng87 added this pull request to the merge queue Feb 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2024
@waynexia
Copy link
Member


Run actions/upload-artifact@v4
With the provided path, there will be 6 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

https://github.com/GreptimeTeam/greptimedb/actions/runs/7985421104/job/21803957658

@tisonkun tisonkun marked this pull request as draft February 21, 2024 07:34
@waynexia
Copy link
Member

Maybe set overwrite to true https://github.com/actions/upload-artifact?tab=readme-ov-file#inputs

Or should we rename the file to contains commit hash?

@tisonkun tisonkun marked this pull request as ready for review February 21, 2024 07:55
@tisonkun
Copy link
Collaborator Author

tisonkun commented Feb 21, 2024

@waynexia it's a simple name conflict within the same job. Resolved.

@tisonkun tisonkun enabled auto-merge February 21, 2024 07:59
@tisonkun tisonkun added this pull request to the merge queue Feb 21, 2024
Merged via the queue into GreptimeTeam:main with commit fa08085 Feb 21, 2024
17 checks passed
@tisonkun tisonkun deleted the node20 branch February 21, 2024 08:21
MichaelScofield pushed a commit to MichaelScofield/greptimedb that referenced this pull request Feb 21, 2024
* ci: upgrade actions to node20-based version

Signed-off-by: tison <[email protected]>

* distinguish artifact name

Signed-off-by: tison <[email protected]>

---------

Signed-off-by: tison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants