From 5a2e28c78ab4a6804e25460f071ac27f74bdb556 Mon Sep 17 00:00:00 2001 From: tison Date: Wed, 21 Feb 2024 14:49:26 +0800 Subject: [PATCH 1/2] ci: upgrade actions to node20-based version Signed-off-by: tison --- .../actions/build-linux-artifacts/action.yml | 2 +- .../actions/build-macos-artifacts/action.yml | 2 +- .../actions/build-windows-artifacts/action.yml | 2 +- .github/workflows/develop.yml | 18 +++++++++--------- .github/workflows/nightly-ci.yml | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/actions/build-linux-artifacts/action.yml b/.github/actions/build-linux-artifacts/action.yml index 03c7239677c2..26eb4c81c09f 100644 --- a/.github/actions/build-linux-artifacts/action.yml +++ b/.github/actions/build-linux-artifacts/action.yml @@ -34,7 +34,7 @@ runs: - name: Upload sqlness logs if: ${{ failure() && inputs.disable-run-tests == 'false' }} # Only upload logs when the integration tests failed. - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: sqlness-logs path: /tmp/greptime-*.log diff --git a/.github/actions/build-macos-artifacts/action.yml b/.github/actions/build-macos-artifacts/action.yml index 6b1cf6b03ba8..0b2d42cebb63 100644 --- a/.github/actions/build-macos-artifacts/action.yml +++ b/.github/actions/build-macos-artifacts/action.yml @@ -67,7 +67,7 @@ runs: - name: Upload sqlness logs if: ${{ failure() }} # Only upload logs when the integration tests failed. - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: sqlness-logs path: /tmp/greptime-*.log diff --git a/.github/actions/build-windows-artifacts/action.yml b/.github/actions/build-windows-artifacts/action.yml index 879473aa7d93..05eb7249afb2 100644 --- a/.github/actions/build-windows-artifacts/action.yml +++ b/.github/actions/build-windows-artifacts/action.yml @@ -62,7 +62,7 @@ runs: - name: Upload sqlness logs if: ${{ failure() }} # Only upload logs when the integration tests failed. - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: sqlness-logs path: ${{ runner.temp }}/greptime-*.log diff --git a/.github/workflows/develop.yml b/.github/workflows/develop.yml index 92f972fbd306..9852a73d49cc 100644 --- a/.github/workflows/develop.yml +++ b/.github/workflows/develop.yml @@ -1,7 +1,7 @@ on: merge_group: pull_request: - types: [opened, synchronize, reopened, ready_for_review] + types: [ opened, synchronize, reopened, ready_for_review ] paths-ignore: - 'docs/**' - 'config/**' @@ -57,7 +57,7 @@ jobs: toolchain: ${{ env.RUST_TOOLCHAIN }} - name: Rust Cache uses: Swatinem/rust-cache@v2 - with: + with: # Shares across multiple jobs # Shares with `Clippy` job shared-key: "check-lint" @@ -75,7 +75,7 @@ jobs: toolchain: stable - name: Rust Cache uses: Swatinem/rust-cache@v2 - with: + with: # Shares across multiple jobs shared-key: "check-toml" - name: Install taplo @@ -139,7 +139,7 @@ jobs: # FIXME: Logs cannot found be on failure (or even success). Need to figure out the cause. - name: Upload sqlness logs if: always() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: sqlness-logs path: ${{ runner.temp }}/greptime-*.log @@ -170,7 +170,7 @@ jobs: # FIXME: Logs cannot be found on failure (or even success). Need to figure out the cause. - name: Upload sqlness logs if: always() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: sqlness-logs path: ${{ runner.temp }}/greptime-*.log @@ -191,7 +191,7 @@ jobs: components: rustfmt - name: Rust Cache uses: Swatinem/rust-cache@v2 - with: + with: # Shares across multiple jobs shared-key: "check-rust-fmt" - name: Run cargo fmt @@ -212,7 +212,7 @@ jobs: components: clippy - name: Rust Cache uses: Swatinem/rust-cache@v2 - with: + with: # Shares across multiple jobs # Shares with `Check` job shared-key: "check-lint" @@ -271,7 +271,7 @@ jobs: GT_KAFKA_ENDPOINTS: 127.0.0.1:9092 UNITTEST_LOG_DIR: "__unittest_logs" - name: Codecov upload - uses: codecov/codecov-action@v2 + uses: codecov/codecov-action@v4 with: token: ${{ secrets.CODECOV_TOKEN }} files: ./lcov.info @@ -285,7 +285,7 @@ jobs: runs-on: ubuntu-20.04 timeout-minutes: 60 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Download pre-built binaries uses: actions/download-artifact@v4 with: diff --git a/.github/workflows/nightly-ci.yml b/.github/workflows/nightly-ci.yml index a11073741f45..88a8bc224ae6 100644 --- a/.github/workflows/nightly-ci.yml +++ b/.github/workflows/nightly-ci.yml @@ -45,7 +45,7 @@ jobs: {"text": "Nightly CI failed for sqlness tests"} - name: Upload sqlness logs if: always() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: sqlness-logs path: ${{ runner.temp }}/greptime-*.log From 53325624bc57ef4c0206444854de1ffb33288f81 Mon Sep 17 00:00:00 2001 From: tison Date: Wed, 21 Feb 2024 15:57:23 +0800 Subject: [PATCH 2/2] distinguish artifact name Signed-off-by: tison --- .github/workflows/develop.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/develop.yml b/.github/workflows/develop.yml index 9852a73d49cc..45ace7dbb7cf 100644 --- a/.github/workflows/develop.yml +++ b/.github/workflows/develop.yml @@ -172,7 +172,7 @@ jobs: if: always() uses: actions/upload-artifact@v4 with: - name: sqlness-logs + name: sqlness-logs-with-kafka-wal path: ${{ runner.temp }}/greptime-*.log retention-days: 3