Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge tree data parts #3346

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Feb 21, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Define DataPart and DataParts, and add read method for it.
  • Rename iter method in DataBuffer to read as it no long implements Iterator trait.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 21, 2024
@v0y4g3r v0y4g3r marked this pull request as ready for review February 21, 2024 08:31
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (fa08085) 85.28% compared to head (8269530) 84.87%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3346      +/-   ##
==========================================
- Coverage   85.28%   84.87%   -0.42%     
==========================================
  Files         884      884              
  Lines      144265   144401     +136     
==========================================
- Hits       123042   122565     -477     
- Misses      21223    21836     +613     

src/mito2/src/memtable/merge_tree/data.rs Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Feb 21, 2024
Merged via the queue into GreptimeTeam:main with commit 90169c8 Feb 21, 2024
17 checks passed
@v0y4g3r v0y4g3r deleted the feat/merge-tree-data-parts branch February 21, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants