Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use workspace-wide lints #3352

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

SteveLauC
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Specify clippy lints in Cargo.toml rather than .cargo/config.toml, closes #3344

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3344

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 22, 2024
.cargo/config.toml Outdated Show resolved Hide resolved
@SteveLauC
Copy link
Contributor Author

Ping me if you guys need me to squash my commits

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (860b1e9) 84.99% compared to head (a40f6ea) 84.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3352      +/-   ##
==========================================
- Coverage   84.99%   84.58%   -0.42%     
==========================================
  Files         887      887              
  Lines      145143   145143              
==========================================
- Hits       123365   122769     -596     
- Misses      21778    22374     +596     

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We use Merger Queue and Squash Commits. So you don't have to manually squash the commits.

@tisonkun tisonkun added this pull request to the merge queue Feb 22, 2024
Merged via the queue into GreptimeTeam:main with commit e9a2b0a Feb 22, 2024
16 checks passed
@SteveLauC SteveLauC deleted the chore/lints_in_cargo_toml branch February 22, 2024 01:18
@waynexia waynexia mentioned this pull request Feb 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure lint options in Cargo.toml
3 participants