Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in lint config #3358

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fix a typo from #3352, which would emit warnings like

image

I also add a deny lint to prevent the same error. It works like

image

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <[email protected]>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 22, 2024
@waynexia waynexia added this pull request to the merge queue Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8289b0d) 85.42% compared to head (b5dfee9) 84.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3358      +/-   ##
==========================================
- Coverage   85.42%   84.96%   -0.46%     
==========================================
  Files         889      889              
  Lines      145477   145477              
==========================================
- Hits       124272   123610     -662     
- Misses      21205    21867     +662     

Merged via the queue into GreptimeTeam:main with commit f26505b Feb 22, 2024
17 checks passed
@waynexia waynexia deleted the fix-lint-config branch February 22, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants