Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isnull function #3360

Merged
merged 3 commits into from
Feb 22, 2024
Merged

feat: add isnull function #3360

merged 3 commits into from
Feb 22, 2024

Conversation

KKould
Copy link
Collaborator

@KKould KKould commented Feb 22, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Implement the isnull function to find remainders

  • added a unit test
  • updated the sqlness test

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link

issue: #3355

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (53105b9) 85.38% compared to head (b8c672c) 84.97%.
Report is 3 commits behind head on main.

❗ Current head b8c672c differs from pull request most recent head a0686de. Consider uploading reports for the commit a0686de to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3360      +/-   ##
==========================================
- Coverage   85.38%   84.97%   -0.41%     
==========================================
  Files         889      891       +2     
  Lines      145477   145534      +57     
==========================================
- Hits       124210   123662     -548     
- Misses      21267    21872     +605     

@KKould KKould marked this pull request as draft February 22, 2024 09:53
@KKould KKould marked this pull request as ready for review February 22, 2024 12:02
@KKould KKould marked this pull request as draft February 22, 2024 12:03
@KKould KKould marked this pull request as ready for review February 22, 2024 12:05
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, appreciate it @KKould 🚀

tests/cases/standalone/common/function/expression.sql Outdated Show resolved Hide resolved
@KKould KKould requested a review from waynexia February 22, 2024 12:21
@waynexia waynexia added this pull request to the merge queue Feb 22, 2024
@tisonkun
Copy link
Collaborator

Thanks for your contribution!

Merged via the queue into GreptimeTeam:main with commit 578dd8f Feb 22, 2024
17 checks passed
@tisonkun
Copy link
Collaborator

@KKould out of curiosity, and since there is no linked good first issue, I wonder how you found this project :D

And welcome! You can browse other good first issue or start a discussion at the Discussions forum for anything you are interested in this project.

@KKould
Copy link
Collaborator Author

KKould commented Feb 23, 2024

@KKould out of curiosity, and since there is no linked good first issue, I wonder how you found this project :D

And welcome! You can browse other good first issue or start a discussion at the Discussions forum for anything you are interested in this project.

I was a database employee and followed Greptime for a long time, but I am more interested in things related to SQL queries. I have not encountered many related issues before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants