-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix f64 has no sufficient precision during parsing #3483
fix: fix f64 has no sufficient precision during parsing #3483
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3483 +/- ##
==========================================
- Coverage 85.45% 85.03% -0.43%
==========================================
Files 896 897 +1
Lines 147532 148153 +621
==========================================
- Hits 126080 125982 -98
- Misses 21452 22171 +719 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LCTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WenyXu where do we rely on f64 to JSON to f64? If it's not on the hot path, the performance issue can be insignificant.
The column's default constraint will be serialized into bytes(JSON) when creating the table. However, these changes may also affect the insertion performance. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
fix #3479
What's changed and what's your intention?
Enable the
float_roundtrip
ofserde_json
, it makes f64 -> JSON -> f64 produces output identical to the input.However, this comes at an approximately 2x performance cost for parsing floats compared to the default best-effort precision.
See also:
Checklist