-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove timeout in the channel between frontend and datanode #3962
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
I'm not sure if this behavior is expected. If the query request from the client has already been canceled or aborted, it doesn't make sense for the requests between the frontend and the datanode to continue processing. |
The cancellation should always be controlled by frontend protocol layer or the client. But not timeout-ed by the channel between datanode and frontend. One related enhancement is we don't propagate this cancellation for now. I filed a issue for this #3964 |
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3962 +/- ##
==========================================
- Coverage 85.40% 85.11% -0.30%
==========================================
Files 978 978
Lines 168271 168279 +8
==========================================
- Hits 143717 143224 -493
- Misses 24554 25055 +501 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Don't timeout on gRPC connection from frontend to datanode. For some queries are expected to take a long while.
Checklist