-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implements row group level parallel unordered scanner #3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
evenyag
changed the title
feat: Implements row group level unordered scanner
feat: Implements row group level parallel unordered scanner
May 20, 2024
evenyag
force-pushed
the
feat/unordered-scanner
branch
5 times, most recently
from
May 21, 2024 09:03
85e9cf2
to
209cce9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3992 +/- ##
==========================================
- Coverage 85.44% 85.01% -0.43%
==========================================
Files 980 987 +7
Lines 170140 171396 +1256
==========================================
+ Hits 145379 145716 +337
- Misses 24761 25680 +919 |
fix: missing ranges in scan parts
evenyag
force-pushed
the
feat/unordered-scanner
branch
from
May 23, 2024 13:36
209cce9
to
2d32e74
Compare
waynexia
reviewed
May 24, 2024
replaces ScanPartBuilder with FileRangeCollector which only collect file ranges
fengjiachun
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 tasks
waynexia
approved these changes
May 29, 2024
🛫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR changes the
UnorderedScan
to read parquet row groups in parallel to improve scan performance. It also implements theRegionScanner
trait forUnorderedScan
.build_parts
method toScanInput
to collect allFileRanges
(row groups) and memtablesUnorderedScan
can returnparallelism
streamsCompatBatch
to adapt batch schema.CompatReader
in the future asCompatBatch
doesn't require implementing theBatchReader
trait.It also defines a
ScanPartBuilder
trait to allow different parallel scan strategies.Checklist