-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show flow's mem usage in INFORMATION_SCHEMA.FLOWS #4890
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
39fda57
to
1b0b0ef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4890 +/- ##
==========================================
- Coverage 84.00% 83.63% -0.37%
==========================================
Files 1149 1154 +5
Lines 214820 215540 +720
==========================================
- Hits 180450 180260 -190
- Misses 34370 35280 +910 |
What's the status of this PR? |
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 19 out of 34 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- src/common/meta/src/kv_backend.rs: Evaluated as low risk
- src/common/meta/src/kv_backend/memory.rs: Evaluated as low risk
- src/cmd/src/cli/repl.rs: Evaluated as low risk
- src/flow/src/compute/state.rs: Evaluated as low risk
- src/cmd/src/error.rs: Evaluated as low risk
- src/common/meta/src/key/flow.rs: Evaluated as low risk
- src/catalog/src/error.rs: Evaluated as low risk
- src/common/meta/src/key.rs: Evaluated as low risk
- src/flow/src/repr.rs: Evaluated as low risk
- scripts/check-snafu.py: Evaluated as low risk
- src/flow/src/error.rs: Evaluated as low risk
- src/flow/Cargo.toml: Evaluated as low risk
- src/catalog/src/system_schema/information_schema.rs: Evaluated as low risk
- src/catalog/src/system_schema/information_schema/flows.rs: Evaluated as low risk
- src/cmd/src/lib.rs: Evaluated as low risk
Comments skipped due to low confidence (1)
src/flow/src/adapter.rs:183
- [nitpick] The method name 'with_state_report_handler' is ambiguous. Consider renaming it to 'set_state_report_handler'.
pub async fn with_state_report_handler(self, handler: StateReportHandler) -> Self {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've skimmed this and it looks good to me in general
55f64cf
to
a7fc29a
Compare
I need to refactor this pr to make it more similiar to |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Add a column to show flow's mem usage in system table, so one can tune flow's ttl option as needed.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
in distributed mode Flownode's heartbeat task will reguarly ask for a
StateReport
which include all flows' mem usage data, and send them to metasrv, then metasrv can use this info to build system table, however there is a small latency in data update since heartbeat duration is in seconds but this usually is ok since flow's mem usage grow very slowly usually. In standalone mode can just query flow's mem sizeChecklist