Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we get fw version before submitting tx request #35

Closed
alex-miller-0 opened this issue Mar 23, 2022 · 1 comment
Closed

Make sure we get fw version before submitting tx request #35

alex-miller-0 opened this issue Mar 23, 2022 · 1 comment

Comments

@alex-miller-0
Copy link
Contributor

For Lattices on fw >0.15.0 we make a different type of signing request. We only do this when this.sdkSession.getFwVersion() shows that we are >0.15.0.

However, we only sync firmware version for connect, not for syncWallet. Thus, the first request returns an "Invalid Request" error from the device. After a connect call, the second request works fine.

We don't need to worry about this yet because 0.15.0 won't be released for a little while but we should get a fix in before that happens.

What we should really do is update firmware to return the wallet UID in connect, then deprecate the fetchActiveWallet route and switch _syncWallet in the keyring for _connect.

@alex-miller-0
Copy link
Contributor Author

_syncWallet was removed and replaced with _connect in #36 so we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant