Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kv tests with new ETH signing path #382

Open
2 tasks
alex-miller-0 opened this issue May 6, 2022 · 0 comments
Open
2 tasks

Update kv tests with new ETH signing path #382

alex-miller-0 opened this issue May 6, 2022 · 0 comments
Assignees
@alex-miller-0

Comments

@alex-miller-0
Copy link
Contributor

There are two things that need to be updated in testKv.ts:

  • Test 'Should make a request with calldata' needs to have decoder data added to the request. This is a simple ERC20 transfer call, so it should be easy to find that ABI
  • ETH_REQ needs to be updated to use the general signing route before the legacy route is dprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-miller-0 alex-miller-0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alex-miller-0