Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all Buffer types to Uint8Arrays #444

Open
alex-miller-0 opened this issue Jul 25, 2022 · 2 comments
Open

Convert all Buffer types to Uint8Arrays #444

alex-miller-0 opened this issue Jul 25, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@alex-miller-0
Copy link
Contributor

Uint8Array types are native to the browser, which is the primary medium for this SDK. Furthermore, these types play nicely with React Native, which would make this SDK much easier to integrate into mobile apps. Long ago when we were building our own mobile wallet, we had a lot of issues with RN/Buffer and had to switch to using the buffer package, which is still un use today.

We should remove all uses of buffer (and its Buffers) and switch to using Uint8Arrays. This will, however, be a large undertaking.

Related to #427

@alex-miller-0 alex-miller-0 added the enhancement New feature or request label Jul 25, 2022
@paulmillr
Copy link

Any backwards compatibility concerns? Or, converting everything and releasing a new version is the plan?

@alex-miller-0
Copy link
Contributor Author

alex-miller-0 commented Jul 25, 2022

Yes this will affect the API so it will require a major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants