Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.6.0 #547

Closed
legobeat opened this issue Feb 25, 2024 · 1 comment
Closed

Release 2.6.0 #547

legobeat opened this issue Feb 25, 2024 · 1 comment

Comments

@legobeat
Copy link
Contributor

legobeat commented Feb 25, 2024

Would be very much appreciated with a published new release at some point to get merged fixes downstream.

@netbonus
Copy link
Contributor

netbonus commented Jun 7, 2024

@legobeat we will be shipping soon:tm: #554

github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this issue Oct 22, 2024
## **Description**

- fix(deps): `[email protected]>~2.6.0`
    - `2.7.0` updates to `@ethereumjs/tx` 5, so holding at 2.6
    - removes dependency on legacy `ethereum-cryptography` v1
- dedupe and unpin `@ethereumjs/tx` to `^4.2.0`
  - `eth-lattice-keyring` is pinned to `@ethereumjs/[email protected]`
  - `gridplus-sdk` is pinned to `@ethereumjs/[email protected]`
- fix(deps): bump `[email protected]>^6.5.7` via resolutions
- fix(deps): bump `secp256k`


[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27973?quickstart=1)

## **Related issues**

- GridPlus/eth-lattice-keyring#64
- GridPlus/gridplus-sdk#547

## **Manual testing steps**


## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
hjetpoluru pushed a commit to MetaMask/metamask-extension that referenced this issue Oct 28, 2024
## **Description**

- fix(deps): `[email protected]>~2.6.0`
    - `2.7.0` updates to `@ethereumjs/tx` 5, so holding at 2.6
    - removes dependency on legacy `ethereum-cryptography` v1
- dedupe and unpin `@ethereumjs/tx` to `^4.2.0`
  - `eth-lattice-keyring` is pinned to `@ethereumjs/[email protected]`
  - `gridplus-sdk` is pinned to `@ethereumjs/[email protected]`
- fix(deps): bump `[email protected]>^6.5.7` via resolutions
- fix(deps): bump `secp256k`


[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27973?quickstart=1)

## **Related issues**

- GridPlus/eth-lattice-keyring#64
- GridPlus/gridplus-sdk#547

## **Manual testing steps**


## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
danjm pushed a commit to MetaMask/metamask-extension that referenced this issue Oct 29, 2024
- fix(deps): `[email protected]>~2.6.0`
    - `2.7.0` updates to `@ethereumjs/tx` 5, so holding at 2.6
    - removes dependency on legacy `ethereum-cryptography` v1
- dedupe and unpin `@ethereumjs/tx` to `^4.2.0`
  - `eth-lattice-keyring` is pinned to `@ethereumjs/[email protected]`
  - `gridplus-sdk` is pinned to `@ethereumjs/[email protected]`
- fix(deps): bump `[email protected]>^6.5.7` via resolutions
- fix(deps): bump `secp256k`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27973?quickstart=1)

- GridPlus/eth-lattice-keyring#64
- GridPlus/gridplus-sdk#547

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
danjm pushed a commit to MetaMask/metamask-extension that referenced this issue Oct 29, 2024
- fix(deps): `[email protected]>~2.6.0`
    - `2.7.0` updates to `@ethereumjs/tx` 5, so holding at 2.6
    - removes dependency on legacy `ethereum-cryptography` v1
- dedupe and unpin `@ethereumjs/tx` to `^4.2.0`
  - `eth-lattice-keyring` is pinned to `@ethereumjs/[email protected]`
  - `gridplus-sdk` is pinned to `@ethereumjs/[email protected]`
- fix(deps): bump `[email protected]>^6.5.7` via resolutions
- fix(deps): bump `secp256k`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27973?quickstart=1)

- GridPlus/eth-lattice-keyring#64
- GridPlus/gridplus-sdk#547

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants