-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularizes the Client class and improves test suite #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglance
force-pushed
the
dl/modularclient
branch
from
June 17, 2022 20:26
aa64886
to
5c10f43
Compare
douglance
force-pushed
the
dl/modularclient
branch
from
June 21, 2022 14:58
5c10f43
to
6bfabf0
Compare
douglance
force-pushed
the
dl/modularclient
branch
3 times, most recently
from
June 23, 2022 00:19
0926aa3
to
4c37fe9
Compare
douglance
force-pushed
the
dl/modularclient
branch
from
June 23, 2022 13:37
4c37fe9
to
f7ef2be
Compare
douglance
force-pushed
the
dl/modularclient
branch
from
June 23, 2022 20:16
669e18e
to
3ba8c3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow that was a long review 😵
Really really good rewrite!
Left various comments on small stuff
This was referenced Jun 24, 2022
douglance
added a commit
that referenced
this pull request
Jun 27, 2022
douglance
added a commit
that referenced
this pull request
Jun 27, 2022
douglance
force-pushed
the
dl/modularclient
branch
from
June 27, 2022 21:01
991ebaa
to
10eb9e0
Compare
douglance
force-pushed
the
dl/modularclient
branch
from
June 28, 2022 15:55
10eb9e0
to
388ef63
Compare
alex-miller-0
approved these changes
Jun 28, 2022
KevinVitale
approved these changes
Jul 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Client
src/client.ts
has been broken up intosrc/client.ts
,src/functions/
, andsrc/shared/
Tests
tests/
has been moved tosrc/__test__/
and renamed toe2e
tests/*
has had it's ending changed from.ts
to.test.ts
test.only
orit.only
) for debugging.vitest
as the test runner (replacests-mocha
/chai
)src/__test__/unit
.only
onto any failing test to inspect it more closely without other tests interfering.it.only()
,test.only()
ordescribe.only()