Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: gt_substitute_compiletime_symbols() calls ConstantPropagation #1837

Open
philip-paul-mueller opened this issue Jan 30, 2025 · 0 comments
Labels
gt4py.next Issues concerning the new version with support for non-cartesian grids.

Comments

@philip-paul-mueller
Copy link
Contributor

gt_simplify() was explicitly designed such that ConstantPropagation is not called.
This is the main reason why ADR18 explicitly forbids to calls the native dace simplification pipeline.
However, gt_substitute_compiletime_symbols() does calls it, for various reasons, but the implementation is not optimal, because some cases are not handled at all and there is some other strange behaviour.

It also called problems during an update of DaCe.
So we should rework this function to avoid the need to call ConstantPropagation.

@romanc romanc added the gt4py.next Issues concerning the new version with support for non-cartesian grids. label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gt4py.next Issues concerning the new version with support for non-cartesian grids.
Projects
None yet
Development

No branches or pull requests

2 participants