Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control on border attribute #582

Open
mrvkino opened this issue Nov 26, 2021 · 4 comments · May be fixed by #838
Open

Add control on border attribute #582

mrvkino opened this issue Nov 26, 2021 · 4 comments · May be fixed by #838

Comments

@mrvkino
Copy link

mrvkino commented Nov 26, 2021

Hi,

I tried to reproduce the following highlight of a tag

image

But I found out it is not possible with the control given. The closest I got was:

image

I would like to have the following control:

"border": "1px solid #2aa198"

Maybe I missed something, but looking at the issue and documentation it seems border control is limited to radius.

Thanks

@mrvkino
Copy link
Author

mrvkino commented Nov 26, 2021

I was wondering why we cannot put any of the qualifiers defined in the VSCode CSS instead of having each of them processed individually as done here?

Is there a performance or discoverability idea behind that?

@Gruntfuggly
Copy link
Owner

Yes, unfortunately the styling very limited. I would also like to be able to put an outline around the highlight, but it doesn't work.

The reason the entire set of rules isn't available is that they have to be applied as a decoration and originally a lot of them were not available. It might be simpler to provide a way to specify any of them, although a lot of them will not make any sense.

I'll add it as a feature request and see if something can be done.

@mrvkino
Copy link
Author

mrvkino commented Nov 30, 2021

In the meantime, If adding the border styling can be done in a similar fashion as the other (aka I can copy the structure), I can try to give It a shot.

I have not done much JavaScript/TypeScript development, but I can try to help.

@eversonl
Copy link

eversonl commented Mar 7, 2024

border options are now available in the API, can these be added now? I've checked and "border": "1px solid #2aa198" still doesnt work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants