From 4486cbedd25e6398b879427020479c96d71f9780 Mon Sep 17 00:00:00 2001 From: James S Date: Wed, 26 Aug 2020 10:31:53 -0700 Subject: [PATCH] fix: Support 0 length messages (#34) * Support 0 length messages, which are valid * Update contributing.md * Add specs * linter Co-authored-by: James Shkolnik --- CONTRIBUTING.md | 75 ++++++++++++++++++- lib/grpc_web/message_framing.rb | 3 +- .../envoy_server_ruby_client_spec.rb | 8 ++ .../integration/ruby_server_js_client_spec.rb | 25 +++++++ .../ruby_server_nodejs_client_spec.rb | 12 ++- .../ruby_server_ruby_client_spec.rb | 8 ++ spec/js-client-src/client.js | 3 +- spec/node-client/client.ts | 42 +++++++---- spec/pb-src/hello.proto | 11 ++- spec/support/test_hello_service.rb | 4 + spec/unit/grpc_web/message_framing_spec.rb | 13 +--- 11 files changed, 171 insertions(+), 33 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c697c9d..79052c3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -8,8 +8,75 @@ Use the `rake` command to run the entire test suite. This runs on docker due to Unit tests can be run without docker by running `rspec spec/unit` -### Commit message format +### Pull Request title/description format -Please follow semantic release formatting -https://semantic-release.gitbook.io/semantic-release/#commit-message-format -https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#type +Each Pull Request description consists of a **header**, a **body** and a **footer**. The header has a special format that includes a **type**, a **scope** and a **subject**: + +```commit +(): + + + +