Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So after i updated to v5.0.0 the disenchant cost has channged #10

Closed
FearlessNite345 opened this issue Jul 28, 2024 · 3 comments
Closed

Comments

@FearlessNite345
Copy link

so on 4.0.0 it costed 15 for

Base Value: 10
Enchantments: Unbreaking (level 3), Repairing (level 2), Thrive (level 1)
Multiplication Factor: 0.25

but on 5.0.0 it now costs 17 has something changed?

i didnt change the config values

@H7KZ
Copy link
Owner

H7KZ commented Jul 29, 2024

Reviewed it, refactored it, fixed it, should be 18 xp :DDDDDD

base = 10, unbreaking = 3, repairing = 2, thrive = 1, multiplier = 0.25

Calculate:
10 + (1 * 1) = 11 base + (thrive * multiplier)
11 + (2 * 1.25) = 13.5 base + (repairing * multiplier)
13.5 + (3 * 1.5) = 18 base + (unbreaking * multiplier)

In total 18xp

Will be fixed in v5.1.0 (also adding more custom plugin supports)

@H7KZ H7KZ closed this as completed Aug 4, 2024
@ejm554
Copy link

ejm554 commented Aug 8, 2024

@H7KZ : Could you explain more about how the multiplier works in your example where you started out by saying that the multiplier = 0.25 ?:

... multiplier = 0.25

10 + (1 * 1) = 11 base + (thrive * multiplier)
11 + (2 * 1.25) = 13.5 base + (repairing * multiplier)
13.5 + (3 * 1.5) = 18 base + (unbreaking * multiplier)

If I'm reading this example correctly, the multipliers in the three operations are 1, then 1.25, and then 1.5. How/why are these multipliers changing by factors of 4, 5, and 6, respectively?

When I read your list of starting values here (and in config.yml), it suggested to me that these were constants and shouldn't change. In other words, I would have assumed that the multiplier should always be 0.25, and never vary. Clearly, I'm misunderstanding.

@H7KZ
Copy link
Owner

H7KZ commented Aug 10, 2024

With each enchantment the disenchantment gets progressively more expensive due to multiplier stacking up. With each iteration the multiplier adds it self to make the next enchantment more expensive.

So with 4 enchantments the multiplier of 0.4 will, at the final enchantment, be 1.6

  1. First Enchantment will be multiplied by 0.4
  2. Second enchantment will be multiplied by 0.8
  3. Third by 1.2
  4. Fourh by 1.6

If you feel this is somehow unbalanced or confusing at counting, please say so! It is easily changeable :)

@H7KZ H7KZ reopened this Aug 10, 2024
@H7KZ H7KZ closed this as completed Aug 22, 2024
@H7KZ H7KZ closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants