Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_offset_t < size_t on mingw #3091

Open
mulimoen opened this issue Jun 9, 2023 · 6 comments
Open

file_offset_t < size_t on mingw #3091

mulimoen opened this issue Jun 9, 2023 · 6 comments
Assignees
Labels
Component - C Library Core C library issues (usually in the src directory) Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub UNCONFIRMED New issues are unconfirmed until a maintainer can duplicate them
Milestone

Comments

@mulimoen
Copy link

mulimoen commented Jun 9, 2023

Describe the bug
Using the mingw toolchain we encounter a problem in the assertation on the following

assert(sizeof(file_offset_t) >= sizeof(size_t));
which crashes the program

Expected behavior
The assertation to not trigger a crash.

Platform

  • Default windows github runner
  • HDF5 version 1.14.1-2 from source
  • Microsoft Windows Server 2022
  • Mingw-w64 11.2.0
  • CMake 3.26.4

Additional context

@glennsong09 glennsong09 added Component - C Library Core C library issues (usually in the src directory) Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub UNCONFIRMED New issues are unconfirmed until a maintainer can duplicate them labels Jun 9, 2023
@derobins
Copy link
Member

We don't have great testing for MinGW, but I would like to get that set up as a GitHub action ASAP so we can fix these issues.

@derobins derobins added the Priority - 1. High 🔼 These are important issues that should be resolved in the next release label Jun 10, 2023
@derobins derobins changed the title [BUG] file_offset_t < size_t on mingw file_offset_t < size_t on mingw Jun 10, 2023
@aldanor
Copy link

aldanor commented Jun 10, 2023

@derobins mingw builds are very easy to set up on github actions (you can check hdf5-rust CI as an example).

Would really appreciate if this was looked into since it's currently a blocker for us bundling 1.14 for static builds.

@derobins
Copy link
Member

derobins commented Jun 13, 2023

@aldanor and/or @mulimoen - shoot me an email at derobins at hdfgroup dot org and we'll get this fixed.

@derobins
Copy link
Member

Is this still a problem? We build and test MinGW in several environments now and we don't see this assert being tripped.

@mulimoen
Copy link
Author

@derobins
Copy link
Member

derobins commented Nov 4, 2024

Let me know if this PR fixes the problem. It should be merged in the next day or so.

#5064

Update: It's in. Let me know if this fixes your problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - C Library Core C library issues (usually in the src directory) Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub UNCONFIRMED New issues are unconfirmed until a maintainer can duplicate them
Projects
None yet
Development

No branches or pull requests

5 participants