Skip to content

The option HDF5_ENABLE_THREADS is not used correctly #5517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
byrnHDF opened this issue May 6, 2025 · 0 comments · Fixed by #5523
Closed

The option HDF5_ENABLE_THREADS is not used correctly #5517

byrnHDF opened this issue May 6, 2025 · 0 comments · Fixed by #5523
Assignees
Labels
Component - Build CMake, Autotools Priority - 2. Medium It would be nice to have this in the next release

Comments

@byrnHDF
Copy link
Contributor

byrnHDF commented May 6, 2025

The option is used to link in Threads libs but the option is not used correctly.
The proper solution is the add the Threads lib to a global CMake variable when threads is available. Then use this variable to link. The current usage of the HDF5_ENABLE_THREADS option will cause a link issue if Threads library is not found.

@github-project-automation github-project-automation bot moved this to To be triaged in HDF5 - TRIAGE & TRACK May 8, 2025
@glennsong09 glennsong09 added Component - Build CMake, Autotools Priority - 2. Medium It would be nice to have this in the next release labels May 21, 2025
@nbagha1 nbagha1 moved this from To be triaged to Backlog in HDF5 - TRIAGE & TRACK May 23, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in HDF5 - TRIAGE & TRACK Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Build CMake, Autotools Priority - 2. Medium It would be nice to have this in the next release
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants