Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-triplication of CLD detector constructors / compact files in key4hep-stack #11

Open
vvolkl opened this issue Jun 7, 2021 · 2 comments
Open

De-triplication of CLD detector constructors / compact files in key4hep-stack #11

vvolkl opened this issue Jun 7, 2021 · 2 comments

Comments

@vvolkl
Copy link
Member

vvolkl commented Jun 7, 2021

Some detector source / compact files are currently present in triplicate in the key4hep-stack - in DetFCCeeIDEA, DetFCCeeCLD and LCGEO. Since historically the CLD detector model was in LCGEO, I'd propose to keep the files there and only keep a master .xml in this repo that uses $LCGEO for includes.
@EmanuelPerez
Copy link
Contributor

A cleaning has to be done, yes. If I remember well, the description in these several places is identical, although the xmls are not. One should be very careful and not use an inconsistent set of files.

@vvolkl
Copy link
Member Author

vvolkl commented Jun 7, 2021

Yes indeed - there is already a versioning scheme in LCGEO, so I would just move the xml files as they are here to FCCee_o2_v02 or FCCee_o3_v01. The changes in the c++ are mostly about using the sensitive detectors from FCCSW I think - here it should be possible to add a configuration option to change the sensitive detector from Gaudi, similar to what is done in ddsim.

@vvolkl vvolkl mentioned this issue Jun 28, 2021
Closed
atolosadelgado pushed a commit to atolosadelgado/FCCDetectors that referenced this issue Dec 6, 2022
@SanghyunKo
Migrate SIM step to EDM4hep (HEP-FCC#11)
2c48b2d 
* take care corner cases of small # of rotations in phi

* estimate numx & numy on-the-fly instead of saving them in CellID (overflow of field with small # of rotations)

* fix readouts

* workaround for HSF CMakeTools (for LCG >= 97a_FCC_4)

* [WIP] edm4hep + alpha for DR calorimeter (1)

* [WIP] edm4hep + alpha for DR calorimeter (1)

* [WIP] edm4hep + alpha for DR calorimeter (2)

* [WIP] edm4hep + alpha for DR calorimeter (2)

* migrate to EDM4hep (G4 part only)

* handle fiber allocation corner cases

* use RawCalorimeterHit instead of SimCalorimeterHit

* CMake clean-up

* move to LCG_99 (LCG_97a_FCC4 not working)

* CMake clean-up

* fix segmentation fault

* migrate to G4.10.07.p01 and fix for multithreading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vvolkl @EmanuelPerez