Select testing framework

[Sinclert]

I am looking into this repository, as it was mentioned in this HEP-Data issue, and I see that there are 2 testing frameworks defined: unittest and pytest.

• unittest is present on the tests definitions. Example:

      class SubmissionFileValidationTest(unittest.TestCase):
          ...

• pytests is present on the project dependencies and... setup.py? 🤷🏻‍♂️

Right now, both execution works:

pytests testsuite

python -m unittest testsuite/validation_test.py

However, I find it confusing, and I think that the original idea was to use pytest, but at some point in time some initial "setUp" steps were needed before some tests. That may be when the unittest syntax was introduced.

Could you decide on a given framework?

I would suggest choosing pytest, and replace unittest syntax by pytest fixtures. I can create a proposed PR if agreed.

[GraemeWatt]

Looking at the history of this repository, the first commit uses only unittest and pytest was introduced later in the second commit (0ed211c). A comment by the original developer indicates that both unittest and pytest were used in the early stages of the project. The hepdata repository for the main web app uses only pytest (including fixtures). The .travis.yml file for this hepdata-validator repository runs pytest testsuite. I agree that it would be good to move to pytest everywhere as a Python testing framework and a PR would be very helpful if you're prepared to do the work. Note that the hepdata-validator code should be compatible with both Python 2 and Python 3 (both are tested in the .travis.yml file).

[Sinclert]

PR addressing the migration: #10