Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy >= 1.9.0 now required #834

Open
zacharymartinot opened this issue Sep 23, 2022 · 1 comment
Open

scipy >= 1.9.0 now required #834

zacharymartinot opened this issue Sep 23, 2022 · 1 comment

Comments

@zacharymartinot
Copy link
Contributor

else you get

  File "/lustre/aoc/projects/hera/zmartino/anaconda3/envs/main/lib/python3.7/site-packages/hera_cal/io.py", line 552, in get_metadata_dict
    most_common_bl_num = scipy.stats.mode(self.baseline_array, keepdims=True)[0][0]
TypeError: mode() got an unexpected keyword argument 'keepdims'

which i happen to see is due to f9d2808 (at least)

Appears scipy now requires python >= 3.8, so that too

@jsdillon
Copy link
Member

Yeah, I added this because I was getting lots of warnings without it. Do you want to add this requirement to the setup and unit testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants