Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev chore/task: Pull data from our database to populate fields implemented in UI before database was ready #90

Closed
8 tasks
pamlo412 opened this issue Oct 12, 2020 · 1 comment
Labels
Backend Flag to indicate the story's focus enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue

Comments

@pamlo412
Copy link
Contributor

pamlo412 commented Oct 12, 2020

Task description:
This chore/task will replace UI-coded values with values pulled from our database. This work is needed for fields implemented before #23 was done.

Acceptance criteria:
The following fields pull the correct values from the database instead of fake values in the UI:

@pamlo412 pamlo412 added the enhancement New feature or request label Oct 12, 2020
@pamlo412 pamlo412 added In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue labels Oct 31, 2020
@SarahJaine SarahJaine added the Backend Flag to indicate the story's focus label Nov 5, 2020
@pamlo412
Copy link
Contributor Author

Closing this story as no longer needed because other stories are covering this need. See links to the other stories above.

rahearn pushed a commit that referenced this issue Dec 17, 2020
* check if env vars can be referenced directly in deploy config

* try as deployments vars, and out of the manifest

* add back to manifest

* was it proactively checking other branches?

* check that we really need vars in manifest

* try migrate as cf run-task in single command

* ignore that failing fe test for now

* omg, this takes forever

* try wo explicit wait

* add back sleep, up to 120; add db connect directions

* move sequelize-cli to production deps

* change migrations path to build dir

* move production sequalizerc to file

* update migration command

* add back all the jobs

* rename prod sequalize config

* missing '

* don't restart app

Co-authored-by: Sarah-Jaine Szekeresh <[email protected]>
rahearn added a commit that referenced this issue Dec 17, 2020
* adhoc-main:
  CD: Run database migrations (#90)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Flag to indicate the story's focus enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue
Projects
None yet
Development

No branches or pull requests

2 participants