[Prod] Don't separate goals by status on the AR. #2165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
There is an ongoing bug where goals are separated by status on an Activity report. We've made many changes to how goal status is managed in the past months. For one, status is no longer editable on a report. We've also removed draft, closed, and suspended goals as options, and goals are moved from not started to in progress automatically. I don't think we need to separate them anymore.
Doing so also resolves this support case, where it is impossible to remove a phantom objective from a report.
How to test
Use the new bin/latest_backup.sh script to download a copy of prod.
Impersonate the user in the video linked in the Jira ticket.
Remove the phantom objective from her report and confirm that it stays gone.
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy