Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prod] Goal source bugfix, update python, don't roll up goals, create hidden monitoring goal template, store uncovered code report as build artifact #2478

Merged
merged 151 commits into from
Nov 14, 2024
Merged

[Prod] Goal source bugfix, update python, don't roll up goals, create hidden monitoring goal template, store uncovered code report as build artifact #2478

merged 151 commits into from
Nov 14, 2024
+3,627 −840

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Nov 13, 2024 •
edited
Loading

Description of change

  • Fix validation for goal source
  • Add Regional Program Director user role

[TTAHUB-3502] Remove goal roll up.
[TTAHUB-3513] Create goal template for CRON monitoring goal.

This PR also includes an update to our version of python, increased test coverage, and a change to our CI to store a report on code uncovered by unit tests.

How to test

  • Confirm that you cannot submit a goal via the RTR or submit an AR without a source
  • Regional Program Director appears as a possible user role in the admin screen but does not appear in the filters

[TTAHUB-3502] Goals on the RTR and merge should be grouped by grant.
[TTAHUB-3513] Nothing to test BE only.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

AdamAdHocTeam and others added 30 commits October 18, 2024 17:08
@AdamAdHocTeam
see what fails
aad392e
@AdamAdHocTeam
add param
9ca1904
@AdamAdHocTeam
add test
47576a7
@AdamAdHocTeam
update e2e for unwind
94c509c
@AdamAdHocTeam
attempt to fix e2e tests
d7cdc42
@AdamAdHocTeam
Merge branch 'main' into al-unwind-goals-on-rtr
a8259dc
@AdamAdHocTeam
see if this fixes one of the e2e
e4057c1
@nvms
add tests for wasGoalPreviouslyClosed
7b4acd9
@nvms
add test for extractObjectiveAssociationsFromActivityReportObjectives
942ade6
@nvms
coverage for the only uncovered nudge branch
db1e705
@nvms
adjust nudge test to correctly cover branch maybe?
0179c64
@AdamAdHocTeam
see if this fixes e2e
0a38789
@AdamAdHocTeam
fix ar e2e
fe7a951
@AdamAdHocTeam
see if wait helps
88f4920
@AdamAdHocTeam
see if this gets further
54a143e
@AdamAdHocTeam
rollback past attempts and increase view port size as sreen was being…
bf07707 
… cutoff
@nvms
in writing tests for findOrFailExistingGoal, maybe fixed a bug
b381dd7
@nvms
add tests for findOrFailExistingGoal
5c63021
@nvms
add reduceGoals.test
35e37c2
@AdamAdHocTeam
select first goal instead
41c5795
@AdamAdHocTeam
fix lint
a4ced78
@AdamAdHocTeam
add scroll down
291354b
@AdamAdHocTeam
set to truthy for now
a302640
@AdamAdHocTeam
roll back resource change for now as it breaks tests
8e0a612
@AdamAdHocTeam
update tess
6adff0b
@AdamAdHocTeam
Merge branch 'main' into al-unwind-goals-on-rtr
e5ebb0c
@AdamAdHocTeam
switch to truthy
6c1989d
@AdamAdHocTeam
changes to similarity to ensure we are rolling up similiar goals by g…
9899c7b 
…rant id
@nvms
coverage for destroyGoal, hopefully
3beb5f8
@nvms
Merge branch 'main' into jp/3440/goalservices-tests
47c2699
thewatermethod and others added 23 commits November 13, 2024 10:26
@thewatermethod
Refine change
a23ae42
@thewatermethod
Update python to 3.9.20
b1be5f4
@thewatermethod
Merge pull request #2475 from HHS/update-python-to-3.9.20
7c7888f 
Update python to 3.9.20
@thewatermethod
Merge branch 'main' into mb/TTAHUB-3581/update-user-role-list-with-re…
b7dd61f 
…gional-program-director
@thewatermethod
Merge branch 'main' into mb/TTAHUB-3611/goal-source-validation
f62003b
@thewatermethod
Revert some e2e changes
09d96c2
@AdamAdHocTeam
Merge pull request #2419 from HHS/al-unwind-goals-on-rtr
3a26a17 
[TTAHUB-3502] Unwind goals on the RTR and Similarity API
@thewatermethod
Merge pull request #2473 from HHS/mb/TTAHUB-3581/update-user-role-lis…
aaee2b3 
…t-with-regional-program-director

[TTAHUB-3581] Add regional program director user role
@AdamAdHocTeam
rename migration
b3634e9
@AdamAdHocTeam
rename again
9e9a5a0
@thewatermethod
Merge pull request #2464 from HHS/mb/TTAHUB-3611/goal-source-validation
69f15ed 
[TTAHUB-3611] Fix goal source validation
@AdamAdHocTeam
Merge branch 'main' into al-ttahub-3513-add-system-generated-creation…
b9b7160 
…-method
@AdamAdHocTeam
Merge pull request #2469 from HHS/al-ttahub-3513-add-system-generated…
5fe6d21 
…-creation-method

[TTAHUB-3513] Create 'System Created' enum for GoalTemplates
@thewatermethod
Fix e2e test
d086a59
@thewatermethod
Merge remote-tracking branch 'origin/main' into mb/fix-close-goal-e2e…
9db95ee 
…-test
@thewatermethod
Merge pull request #2476 from HHS/mb/fix-close-goal-e2e-test
13a2077 
Fix e2e test
remove unneeded date correction logic
dd587fc
add more comments per review and use more legible regex
75c459b
Merge branch 'main' into ttahub-3451/format_comlog_comdate_history
8947528
@GarrettEHill
postgres does not exists as a user in deployed envs, causing migratio…
3018f22 
…n to fail
freshen migration prefix
67069b1
@hardwarehuman
Merge pull request #2467 from HHS/ttahub-3451/format_comlog_comdate_h…
0329ad7 
…istory

[TTAHUB-3451]format comlog comdate history
@GarrettEHill
Merge pull request #2482 from HHS/TTAHUB-3628/migration-issue
a6c7c63 
[TTAHUB-3628] Migration deployment issue
@thewatermethod thewatermethod marked this pull request as ready for review November 14, 2024 18:47
@kryswisnaskas
Copy link
Collaborator

Merging since this includes critical production fixes.

@kryswisnaskas kryswisnaskas merged commit 4b59d5f into production Nov 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kryswisnaskas kryswisnaskas kryswisnaskas approved these changes

@Jones-QuarteyDana Jones-QuarteyDana Awaiting requested review from Jones-QuarteyDana

@hpeasley hpeasley Awaiting requested review from hpeasley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thewatermethod @kryswisnaskas @AdamAdHocTeam @nvms @GarrettEHill @hardwarehuman